ASoC: max98090: exit workaround earlier if PLL is locked (6f49919d) · Commits · 戴 / test

According to the datasheet, PLL lock time typically takes 2 msec and at most takes 7 msec. Check the lock status every 1 msec and exit the workaround if PLL is locked. Signed-off-by:

Tzung-Bi Shih <tzungbi@google.com> Link: https://lore.kernel.org/r/20191122073114.219945-3-tzungbi@google.com Reviewed-by:

Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Signed-off-by:

Mark Brown <broonie@kernel.org>

sound/soc/codecs/max98090.c

+12 −2

Original line number	Diff line number	Diff line
		@@ -2108,6 +2108,8 @@ static void max98090_pll_work(struct work_struct *work)
		struct max98090_priv *max98090 =
		container_of(work, struct max98090_priv, pll_work);
		struct snd_soc_component *component = max98090->component;
		unsigned int pll;
		int i;

		if (!snd_soc_component_is_active(component))
		return;
		@@ -2127,8 +2129,16 @@ static void max98090_pll_work(struct work_struct *work)
		snd_soc_component_update_bits(component, M98090_REG_DEVICE_SHUTDOWN,
		M98090_SHDNN_MASK, M98090_SHDNN_MASK);

		for (i = 0; i < 10; ++i) {
		/* Give PLL time to lock */
		msleep(10);
		usleep_range(1000, 1200);

		/* Check lock status */
		pll = snd_soc_component_read32(
		component, M98090_REG_DEVICE_STATUS);
		if (!(pll & M98090_ULK_MASK))
		break;
		}
		}

		static void max98090_jack_work(struct work_struct *work)

Admin message