Commit 6f153bcf authored Aug 08, 2019 by Bart Van Assche Committed by Martin K. Petersen Aug 12, 2019

scsi: qla2xxx: Complain if parsing the version string fails



This patch fixes a Coverity complaint about not checking the sscanf()
return value.

Cc: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Tested-by: Himanshu Madhani <hmadhani@marvell.com>
Reviewed-by: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 58e060e1

drivers/scsi/qla2xxx/qla_tmpl.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -860,8 +860,9 @@ qla27xx_driver_info(struct qla27xx_fwdt_template *tmp)
		{
		uint8_t v[] = { 0, 0, 0, 0, 0, 0 };

		sscanf(qla2x00_version_str, "%hhu.%hhu.%hhu.%hhu.%hhu.%hhu",
		v+0, v+1, v+2, v+3, v+4, v+5);
		WARN_ON_ONCE(sscanf(qla2x00_version_str,
		"%hhu.%hhu.%hhu.%hhu.%hhu.%hhu",
		v+0, v+1, v+2, v+3, v+4, v+5) != 6);

		tmp->driver_info[0] = v[3] << 24 \| v[2] << 16 \| v[1] << 8 \| v[0];
		tmp->driver_info[1] = v[5] << 8 \| v[4];

Admin message