Commit 6ef3de9c authored Sep 13, 2013 by David Sterba Committed by Chris Mason Sep 21, 2013

btrfs: refuse to remount read-write after abort



It's still possible to flip the filesystem into RW mode after it's
remounted RO due to an abort. There are lots of places that check for
the superblock error bit and will not write data, but we should not let
the filesystem appear read-write.

Signed-off-by: David Sterba <dsterba@suse.cz>
Signed-off-by: Josef Bacik <jbacik@fusionio.com>
Signed-off-by: Chris Mason <chris.mason@fusionio.com>

parent 1cecf579

fs/btrfs/super.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -1340,6 +1340,12 @@ static int btrfs_remount(struct super_block sb, int flags, char *data)
		if (ret)
		goto restore;
		} else {
		if (test_bit(BTRFS_FS_STATE_ERROR, &root->fs_info->fs_state)) {
		btrfs_err(fs_info,
		"Remounting read-write after error is not allowed\n");
		ret = -EINVAL;
		goto restore;
		}
		if (fs_info->fs_devices->rw_devices == 0) {
		ret = -EACCES;
		goto restore;

Admin message