Commit 6edac6fd authored by Dan Carpenter's avatar Dan Carpenter Committed by Jiri Kosina
Browse files

HID: hidraw: silence an uninitialized variable warning 



My static checker complains that "devid" can be uninitialized if
alloc_chrdev_region() fails.  Fix this by moving the error hanling
forward a couple lines.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent 85d08340

drivers/hid/hidraw.c

+2 −3
Original line number Diff line number Diff line
@@ -587,14 +587,13 @@ int __init hidraw_init(void) 


	result = alloc_chrdev_region(&dev_id, HIDRAW_FIRST_MINOR,

			HIDRAW_MAX_DEVICES, "hidraw");



	hidraw_major = MAJOR(dev_id);



	if (result < 0) {

		pr_warn("can't get major number\n");

		goto out;

	}



	hidraw_major = MAJOR(dev_id);



	hidraw_class = class_create(THIS_MODULE, "hidraw");

	if (IS_ERR(hidraw_class)) {

		result = PTR_ERR(hidraw_class);

CRA Git | Maintained and supported by SUSTech CRA and CCSE