Commit 6ecbc4e1 authored Jul 30, 2006 by Josh Triplett Committed by Linus Torvalds Jul 31, 2006

[PATCH] Remove incorrect unlock_kernel from allocation failure path in coda_open()



Commit 398c53a757702e1e3a7a2c24860c7ad26acb53ed (in the historical GIT
tree) moved the lock_kernel() in coda_open after the allocation of a
coda_file_info struct, but left an unlock_kernel() in the allocation
failure error path; remove it.

Signed-off-by: Josh Triplett <josh@freedesktop.org>
Acked-by: Jan Harkes <jaharkes@cs.cmu.edu>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent 3ae19208

fs/coda/file.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -136,10 +136,8 @@ int coda_open(struct inode coda_inode, struct file coda_file)
		coda_vfs_stat.open++;

		cfi = kmalloc(sizeof(struct coda_file_info), GFP_KERNEL);
		if (!cfi) {
		unlock_kernel();
		if (!cfi)
		return -ENOMEM;
		}

		lock_kernel();

Admin message