Commit 6ebb827f authored Feb 07, 2020 by YueHaibing Committed by Vinod Koul Feb 13, 2020

dmaengine: sun4i: use 'linear_mode' in sun4i_dma_prep_dma_cyclic



drivers/dma/sun4i-dma.c: In function sun4i_dma_prep_dma_cyclic:
drivers/dma/sun4i-dma.c:672:24: warning:
 variable linear_mode set but not used [-Wunused-but-set-variable]

commit ffc079a4 ("dmaengine: sun4i: Add support for cyclic requests with dedicated DMA")
involved this, explicitly using the value makes the code more readable.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Link: https://lore.kernel.org/r/20200207024445.44600-1-yuehaibing@huawei.com


Signed-off-by: Vinod Koul <vkoul@kernel.org>

parent 5ca3364a

drivers/dma/sun4i-dma.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -698,10 +698,12 @@ sun4i_dma_prep_dma_cyclic(struct dma_chan *chan, dma_addr_t buf, size_t len,
		endpoints = SUN4I_DMA_CFG_DST_DRQ_TYPE(vchan->endpoint) \|
		SUN4I_DMA_CFG_DST_ADDR_MODE(io_mode) \|
		SUN4I_DMA_CFG_SRC_DRQ_TYPE(ram_type);
		SUN4I_DMA_CFG_SRC_ADDR_MODE(linear_mode);
		} else {
		src = sconfig->src_addr;
		dest = buf;
		endpoints = SUN4I_DMA_CFG_DST_DRQ_TYPE(ram_type) \|
		SUN4I_DMA_CFG_DST_ADDR_MODE(linear_mode) \|
		SUN4I_DMA_CFG_SRC_DRQ_TYPE(vchan->endpoint) \|
		SUN4I_DMA_CFG_SRC_ADDR_MODE(io_mode);
		}

Admin message