Commit 6eb3c3d0 authored Mar 07, 2019 by Oleg Nesterov Committed by Linus Torvalds Mar 07, 2019

exec: increase BINPRM_BUF_SIZE to 256

Large enterprise clients often run applications out of networked file
systems where the IT mandated layout of project volumes can end up
leading to paths that are longer than 128 characters.  Bumping this up
to the next order of two solves this problem in all but the most
egregious case while still fitting into a 512b slab.

[oleg@redhat.com: update comment, per Kees]
Link: http://lkml.kernel.org/r/20181112160956.GA28472@redhat.com


Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Reported-by: Ben Woodard <woodard@redhat.com>
Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
Acked-by: Michal Hocko <mhocko@suse.com>
Acked-by: Kees Cook <keescook@chromium.org>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 26e15225

fs/exec.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1563,7 +1563,7 @@ static void bprm_fill_uid(struct linux_binprm *bprm)

		/*
		* Fill the binprm structure from the inode.
		* Check permissions, then read the first 128 (BINPRM_BUF_SIZE) bytes
		* Check permissions, then read the first BINPRM_BUF_SIZE bytes
		*
		* This may be called multiple times for binary chains (scripts for example).
		*/

include/uapi/linux/binfmts.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -16,6 +16,6 @@ struct pt_regs;
		#define MAX_ARG_STRINGS 0x7FFFFFFF

		/* sizeof(linux_binprm->buf) */
		#define BINPRM_BUF_SIZE 128
		#define BINPRM_BUF_SIZE 256

		#endif /* _UAPI_LINUX_BINFMTS_H */

Admin message