Commit 6eaeedc1 authored Feb 15, 2020 by Sergei Shtylyov Committed by David S. Miller Feb 16, 2020

sh_eth: check sh_eth_cpu_data::no_tx_cntrs when dumping registers

When adding the sh_eth_cpu_data::no_tx_cntrs flag I forgot to add the
flag check to __sh_eth_get_regs(), causing the non-existing TX counter
registers to be considered for dumping on the R7S72100 SoC (the register
offset sanity check has the final say here)...

Fixes: ce9134df ("sh_eth: add sh_eth_cpu_data::no_tx_cntrs flag")
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Tested-by: Chris Brandt <chris.brandt@renesas.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 5652b46e

drivers/net/ethernet/renesas/sh_eth.c

+6 −4

Original line number	Diff line number	Diff line
		@@ -2184,10 +2184,12 @@ static size_t __sh_eth_get_regs(struct net_device ndev, u32 buf)
		add_reg(BCULR);
		add_reg(MAHR);
		add_reg(MALR);
		if (!cd->no_tx_cntrs) {
		add_reg(TROCR);
		add_reg(CDCR);
		add_reg(LCCR);
		add_reg(CNDCR);
		}
		add_reg(CEFCR);
		add_reg(FRECR);
		add_reg(TSFRCR);