Commit 6eadbf4c authored May 12, 2017 by Darrick J. Wong

xfs: BMAPX shouldn't barf on inline-format directories



When we're fulfilling a BMAPX request, jump out early if the data fork
is in local format.  This prevents us from hitting a debugging check in
bmapi_read and barfing errors back to userspace.  The on-disk extent
count check later isn't sufficient for IF_DELALLOC mode because da
extents are in memory and not on disk.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>

parent 0daaecac

fs/xfs/xfs_bmap_util.c

+6 −2

Original line number	Diff line number	Diff line
		@@ -582,9 +582,13 @@ xfs_getbmap(
		}
		break;
		default:
		/* Local format data forks report no extents. */
		if (ip->i_d.di_format == XFS_DINODE_FMT_LOCAL) {
		bmv->bmv_entries = 0;
		return 0;
		}
		if (ip->i_d.di_format != XFS_DINODE_FMT_EXTENTS &&
		ip->i_d.di_format != XFS_DINODE_FMT_BTREE &&
		ip->i_d.di_format != XFS_DINODE_FMT_LOCAL)
		ip->i_d.di_format != XFS_DINODE_FMT_BTREE)
		return -EINVAL;

		if (xfs_get_extsz_hint(ip) \|\|

Admin message