Commit 6ea8631d authored Jun 05, 2014 by Arnd Bergmann Committed by Christoph Hellwig Jul 25, 2014

pas16: don't call free_dma()



The pas16 scsi driver does not use DMA, and the call to free_dma()
in its exit function seems to have been copied incorrectly from
another driver but never caused trouble.

One case where it gets in the way is randconfig builds on ARM,
which depending on the configuration does not provide a free_dma()
function, causing this build error:

drivers/scsi/pas16.c: In function 'pas16_release':
drivers/scsi/pas16.c:611:3: error: implicit declaration of function 'free_dma' [-Werror=implicit-function-declaration]
   free_dma(shost->dma_channel);

Removing the incorrect function calls should be the obvious
fix for this, with no downsides.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Finn Thain <fthain@telegraphics.com.au>
Signed-off-by: Christoph Hellwig <hch@lst.de>

parent c86d1ae2

drivers/scsi/pas16.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -607,8 +607,6 @@ static int pas16_release(struct Scsi_Host *shost)
		if (shost->irq)
		free_irq(shost->irq, shost);
		NCR5380_exit(shost);
		if (shost->dma_channel != 0xff)
		free_dma(shost->dma_channel);
		if (shost->io_port && shost->n_io_port)
		release_region(shost->io_port, shost->n_io_port);
		scsi_unregister(shost);

Admin message