Commit 6e9c65d8 authored Apr 28, 2020 by Miquel Raynal

mtd: rawnand: onfi: Drop a useless parameter page read



During detection the logic on the NAND bus is:

    /* Regular ONFI detection */
    1/ read the three NAND parameter pages

    /* Extended parameter page detection */
    2/ send "read the NAND parameter page" commands without reading
       actual data
    3/ move the column pointer to the extended page and read it

If fact, as long as there is nothing happening on the NAND bus between
1/ and 3/, the operation 2/ is redundant so remove it.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Link: https://lore.kernel.org/linux-mtd/20200428094302.14624-8-miquel.raynal@bootlin.com

parent 7e928263

drivers/mtd/nand/raw/nand_onfi.c

+4 −6

Original line number	Diff line number	Diff line
		@@ -47,12 +47,10 @@ static int nand_flash_detect_ext_param_page(struct nand_chip *chip,
		if (!ep)
		return -ENOMEM;

		/* Send our own NAND_CMD_PARAM. */
		ret = nand_read_param_page_op(chip, 0, NULL, 0);
		if (ret)
		goto ext_out;

		/* Use the Change Read Column command to skip the ONFI param pages. */
		/*
		* Use the Change Read Column command to skip the ONFI param pages and
		* ensure we read at the right location.
		*/
		ret = nand_change_read_column_op(chip,
		sizeof(p) p->num_of_param_pages,
		ep, len, true);

Admin message