Commit 6e9105c7 authored Dec 22, 2019 by Hangbin Liu Committed by David S. Miller Dec 24, 2019

gtp: do not confirm neighbor when do pmtu update



When do IPv6 tunnel PMTU update and calls __ip6_rt_update_pmtu() in the end,
we should not call dst_confirm_neigh() as there is no two-way communication.

Although GTP only support ipv4 right now, and __ip_rt_update_pmtu() does not
call dst_confirm_neigh(), we still set it to false to keep consistency with
IPv6 code.

v5: No change.
v4: No change.
v3: Do not remove dst_confirm_neigh, but add a new bool parameter in
    dst_ops.update_pmtu to control whether we should do neighbor confirm.
    Also split the big patch to small ones for each area.
v2: Remove dst_confirm_neigh in __ip6_rt_update_pmtu.

Reviewed-by: Guillaume Nault <gnault@redhat.com>
Acked-by: David Ahern <dsahern@gmail.com>
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 675d76ad

drivers/net/gtp.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -540,7 +540,7 @@ static int gtp_build_skb_ip4(struct sk_buff skb, struct net_device dev,
		mtu = dst_mtu(&rt->dst);
		}

		rt->dst.ops->update_pmtu(&rt->dst, NULL, skb, mtu, true);
		rt->dst.ops->update_pmtu(&rt->dst, NULL, skb, mtu, false);

		if (!skb_is_gso(skb) && (iph->frag_off & htons(IP_DF)) &&
		mtu < ntohs(iph->tot_len)) {

Admin message