ALSA: line6: Perform sanity check for each URB creation (6e8a914a) · Commits · 戴 / test

LINE6 drivers create stream URBs with a fixed pipe without checking its validity, and this may lead to a kernel WARNING at the submission when a malformed USB descriptor is passed. For avoiding the kernel warning, perform the similar sanity checks for each pipe type at creating a URB. Reported-by:

<syzbot+c190f6858a04ea7fbc52@syzkaller.appspotmail.com> Cc: <stable@vger.kernel.org> Link: https://lore.kernel.org/r/s5hv9iv4hq8.wl-tiwai@suse.de Signed-off-by:

Takashi Iwai <tiwai@suse.de>

sound/usb/line6/capture.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -286,6 +286,8 @@ int line6_create_audio_in_urbs(struct snd_line6_pcm *line6pcm)
		urb->interval = LINE6_ISO_INTERVAL;
		urb->error_count = 0;
		urb->complete = audio_in_callback;
		if (usb_urb_ep_type_check(urb))
		return -EINVAL;
		}

		return 0;

sound/usb/line6/playback.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -431,6 +431,8 @@ int line6_create_audio_out_urbs(struct snd_line6_pcm *line6pcm)
		urb->interval = LINE6_ISO_INTERVAL;
		urb->error_count = 0;
		urb->complete = audio_out_callback;
		if (usb_urb_ep_type_check(urb))
		return -EINVAL;
		}

		return 0;

Admin message