Commit 6e7bc478 authored Feb 03, 2017 by Eric Dumazet Committed by David S. Miller Feb 03, 2017

net: skb_needs_check() accepts CHECKSUM_NONE for tx



My recent change missed fact that UFO would perform a complete
UDP checksum before segmenting in frags.

In this case skb->ip_summed is set to CHECKSUM_NONE.

We need to add this valid case to skb_needs_check()

Fixes: b2504a5d ("net: reduce skb_warn_bad_offload() noise")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Willem de Bruijn <willemb@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 79e7fff4

net/core/dev.c

+4 −3

Original line number	Original line	Diff line number	Diff line
	@@ -2637,8 +2637,9 @@ EXPORT_SYMBOL(skb_mac_gso_segment);
	static inline bool skb_needs_check(struct sk_buff *skb, bool tx_path)		static inline bool skb_needs_check(struct sk_buff *skb, bool tx_path)
	{		{
	if (tx_path)		if (tx_path)
	return skb->ip_summed != CHECKSUM_PARTIAL;		return skb->ip_summed != CHECKSUM_PARTIAL &&
	else		skb->ip_summed != CHECKSUM_NONE;

	return skb->ip_summed == CHECKSUM_NONE;		return skb->ip_summed == CHECKSUM_NONE;
	}		}

Admin message