Commit 6e6c6dee authored Sep 22, 2017 by Christophe JAILLET Committed by Greg Kroah-Hartman Oct 03, 2017

staging: rtl8192u: Fix some error handling path



If 'rtl8192_usb_initendpoints()' fails, it may have allocated some
resources that need to be freed. The corresponding is propagated up to
'rtl8192_usb_prob()'. So, in this function if an error
code is returned by 'rtl8192_init()' we should call
'rtl8192_usb_deleteendpoints()'.

Some error handling code is also duplicated in 'rtl8192_init()' and in
'rtl8192_usb_prob()'. This looks harmless because the freed pointers are
set to NULL but it looks confusing.

Fix all that by just moving the 'fail' label and removing duplicated
error handling code from 'rtl8192_ini()'. All this resources freeing will
be handled by 'rtl8192_usb_prob()' directly.

The calling graph is:
rtl8192_usb_probe
  --> rtl8192_init
    --> rtl8192_usb_initendpoints

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 5fef87cb

drivers/staging/rtl8192u/r8192U_core.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -2694,9 +2694,6 @@ static short rtl8192_init(struct net_device *dev)
		err = rtl8192_read_eeprom_info(dev);
		if (err) {
		DMESG("Reading EEPROM info failed");
		kfree(priv->pFirmware);
		priv->pFirmware = NULL;
		free_ieee80211(dev);
		return err;
		}
		rtl8192_get_channel_map(dev);
		@@ -4998,11 +4995,11 @@ static int rtl8192_usb_probe(struct usb_interface *intf,

		fail2:
		rtl8192_down(dev);
		fail:
		kfree(priv->pFirmware);
		priv->pFirmware = NULL;
		rtl8192_usb_deleteendpoints(dev);
		mdelay(10);
		fail:
		free_ieee80211(dev);

		RT_TRACE(COMP_ERR, "wlan driver load failed\n");

Admin message