Commit 6e6c2528 authored May 27, 2020 by Qiushi Wu Committed by Rafael J. Wysocki May 28, 2020

ACPI: sysfs: Fix reference count leak in acpi_sysfs_add_hotplug_profile()



kobject_init_and_add() takes reference even when it fails.
Thus, when kobject_init_and_add() returns an error,
kobject_put() must be called to properly clean up the kobject.

Fixes: 3f8055c3 ("ACPI / hotplug: Introduce user space interface for hotplug profiles")
Signed-off-by: Qiushi Wu <wu000273@umn.edu>
Cc: 3.10+ <stable@vger.kernel.org> # 3.10+
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

parent 9cb1fd0e

drivers/acpi/sysfs.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -993,8 +993,10 @@ void acpi_sysfs_add_hotplug_profile(struct acpi_hotplug_profile *hotplug,

		error = kobject_init_and_add(&hotplug->kobj,
		&acpi_hotplug_profile_ktype, hotplug_kobj, "%s", name);
		if (error)
		if (error) {
		kobject_put(&hotplug->kobj);
		goto err_out;
		}

		kobject_uevent(&hotplug->kobj, KOBJ_ADD);
		return;

Admin message