Commit 6e58f752 authored by Viresh Kumar's avatar Viresh Kumar Committed by Greg Kroah-Hartman
Browse files

ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' 



global_lock is defined as an unsigned long and accessing only its lower
32 bits from sysfs is incorrect, as we need to consider other 32 bits
for big endian 64-bit systems. There are no such platforms yet, but the
code needs to be robust for such a case.

Fix that by changing type of 'global_lock' to u32.

Signed-off-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Acked-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9ffecb10

drivers/acpi/ec_sys.c

+1 −1
Original line number Diff line number Diff line
@@ -128,7 +128,7 @@ static int acpi_ec_add_debugfs(struct acpi_ec *ec, unsigned int ec_device_count) 
	if (!debugfs_create_x32("gpe", 0444, dev_dir, (u32 *)&first_ec->gpe))

		goto error;

	if (!debugfs_create_bool("use_global_lock", 0444, dev_dir,

				 (u32 *)&first_ec->global_lock))

				 &first_ec->global_lock))

		goto error;



	if (write_support)

drivers/acpi/internal.h

+1 −1
Original line number Diff line number Diff line
@@ -138,7 +138,7 @@ struct acpi_ec { 
	unsigned long gpe;

	unsigned long command_addr;

	unsigned long data_addr;

	unsigned long global_lock;

	u32 global_lock;

	unsigned long flags;

	unsigned long reference_count;

	struct mutex mutex;

CRA Git | Maintained and supported by SUSTech CRA and CCSE