Commit 6e4c1677 authored May 09, 2012 by Eugeni Dodonov Committed by Daniel Vetter May 19, 2012

drm/i915: show unknown sdvox registers on hdmi init

This will throw a BUG() message when an unknown sdvox register is
given to intel_hdmi_init. When this happens, things could going to be pretty
much broken afterwards, so we better detect this as soon as possible.

Signed-off-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

parent 5826eca5

drivers/gpu/drm/i915/intel_hdmi.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -661,6 +661,10 @@ void intel_hdmi_init(struct drm_device *dev, int sdvox_reg)
		intel_encoder->clone_mask = (1 << INTEL_HDMIF_CLONE_BIT);
		intel_hdmi->ddc_bus = GMBUS_PORT_DPD;
		dev_priv->hotplug_supported_mask \|= HDMID_HOTPLUG_INT_STATUS;
		} else {
		/* If we got an unknown sdvox_reg, things are pretty much broken
		* in a way that we should let the kernel know about it */
		BUG();
		}

		intel_hdmi->sdvox_reg = sdvox_reg;

Admin message