Commit 6e47666e authored Apr 25, 2020 by Xiyu Yang Committed by Trond Myklebust Apr 25, 2020

NFSv4: Remove unreachable error condition due to rpc_run_task()



nfs4_proc_layoutget() invokes rpc_run_task(), which return the value to
"task". Since rpc_run_task() is impossible to return an ERR pointer,
there is no need to add the IS_ERR() condition on "task" here. So we
need to remove it.

Signed-off-by: Xiyu Yang <xiyuyang19@fudan.edu.cn>
Signed-off-by: Xin Tan <tanxin.ctf@gmail.com>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>

parent efe57fd5

fs/nfs/nfs4proc.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -9191,8 +9191,7 @@ nfs4_proc_layoutget(struct nfs4_layoutget lgp, long timeout)
		nfs4_init_sequence(&lgp->args.seq_args, &lgp->res.seq_res, 0, 0);

		task = rpc_run_task(&task_setup_data);
		if (IS_ERR(task))
		return ERR_CAST(task);

		status = rpc_wait_for_completion_task(task);
		if (status != 0)
		goto out;

Admin message