pinctrl: rk805: Make structures constant (6e28aaab) · Commits · 戴 / test

Static structures rk805_pinctrl_desc and rk805_gpio_chip, of types gpio_chip and pinctrl_desc respectively, are not used except to be copied into the fields of a different variable. Hence make rk805_pinctrl_desc and rk805_gpio_chip both constant to protect them from unintended modification. Issue found with Coccinelle. Signed-off-by:

Nishka Dasgupta <nishkadg.linux@gmail.com> Link: https://lore.kernel.org/r/20190819075757.1753-1-nishkadg.linux@gmail.com Signed-off-by:

Linus Walleij <linus.walleij@linaro.org>

drivers/pinctrl/pinctrl-rk805.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -197,7 +197,7 @@ static int rk805_gpio_get_direction(struct gpio_chip *chip, unsigned int offset)
		return !(val & pci->pin_cfg[offset].dir_msk);
		}

		static struct gpio_chip rk805_gpio_chip = {
		static const struct gpio_chip rk805_gpio_chip = {
		.label = "rk805-gpio",
		.request = gpiochip_generic_request,
		.free = gpiochip_generic_free,
		@@ -404,7 +404,7 @@ static const struct pinconf_ops rk805_pinconf_ops = {
		.pin_config_set = rk805_pinconf_set,
		};

		static struct pinctrl_desc rk805_pinctrl_desc = {
		static const struct pinctrl_desc rk805_pinctrl_desc = {
		.name = "rk805-pinctrl",
		.pctlops = &rk805_pinctrl_ops,
		.pmxops = &rk805_pinmux_ops,

Admin message