Commit 6e27f63e authored by Oleg Nesterov's avatar Oleg Nesterov Committed by Linus Torvalds
Browse files

vfork: kill PF_STARTING 



Previously it was (ab)used by utrace.  Then it was wrongly used by the
scheduler code.

Currently it is not used, kill it before it finds the new erroneous user.

Signed-off-by: default avatarOleg Nesterov <oleg@redhat.com>
Acked-by: default avatarTejun Heo <tj@kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 57b59c4a

include/linux/sched.h

+0 −1
Original line number Diff line number Diff line
@@ -1777,7 +1777,6 @@ extern void thread_group_times(struct task_struct *p, cputime_t *ut, cputime_t * 
/*

 * Per process flags

 */

#define PF_STARTING	0x00000002	/* being created */

#define PF_EXITING	0x00000004	/* getting shut down */

#define PF_EXITPIDONE	0x00000008	/* pi exit done on shut down */

#define PF_VCPU		0x00000010	/* I'm a virtual CPU */

kernel/fork.c

+0 −9
Original line number Diff line number Diff line
@@ -1046,7 +1046,6 @@ static void copy_flags(unsigned long clone_flags, struct task_struct *p) 


	new_flags &= ~(PF_SUPERPRIV | PF_WQ_WORKER);

	new_flags |= PF_FORKNOEXEC;

	new_flags |= PF_STARTING;

	p->flags = new_flags;

}
@@ -1579,14 +1578,6 @@ long do_fork(unsigned long clone_flags, 
			get_task_struct(p);

		}



		/*

		 * We set PF_STARTING at creation in case tracing wants to

		 * use this to distinguish a fully live task from one that

		 * hasn't finished SIGSTOP raising yet.  Now we clear it

		 * and set the child going.

		 */

		p->flags &= ~PF_STARTING;



		wake_up_new_task(p);



		/* forking complete and child started to run, tell ptracer */

CRA Git | Maintained and supported by SUSTech CRA and CCSE