nfit: Continue init even if ARS commands are unimplemented (6e2452df) · Commits · 戴 / test

If firmware doesn't implement any of the ARS commands, take that to mean that ARS is unsupported, and continue to initialize regions without bad block lists. We cannot make the assumption that ARS commands will be unconditionally supported on all NVDIMMs. Reported-by:

Haozhong Zhang <haozhong.zhang@intel.com> Signed-off-by:

Vishal Verma <vishal.l.verma@intel.com> Acked-by:

Xiao Guangrong <guangrong.xiao@linux.intel.com> Tested-by:

Haozhong Zhang <haozhong.zhang@intel.com> Signed-off-by:

Dan Williams <dan.j.williams@intel.com>

drivers/acpi/nfit.c

+11 −4

Original line number	Diff line number	Diff line
		@@ -1590,14 +1590,21 @@ static int acpi_nfit_find_poison(struct acpi_nfit_desc *acpi_desc,
		start = ndr_desc->res->start;
		len = ndr_desc->res->end - ndr_desc->res->start + 1;

		/*
		* If ARS is unimplemented, unsupported, or if the 'Persistent Memory
		* Scrub' flag in extended status is not set, skip this but continue
		* initialization
		*/
		rc = ars_get_cap(nd_desc, ars_cap, start, len);
		if (rc == -ENOTTY) {
		dev_dbg(acpi_desc->dev,
		"Address Range Scrub is not implemented, won't create an error list\n");
		rc = 0;
		goto out;
		}
		if (rc)
		goto out;

		/*
		* If ARS is unsupported, or if the 'Persistent Memory Scrub' flag in
		* extended status is not set, skip this but continue initialization
		*/
		if ((ars_cap->status & 0xffff) \|\|
		!(ars_cap->status >> 16 & ND_ARS_PERSISTENT)) {
		dev_warn(acpi_desc->dev,

Admin message