Commit 6e22ce2c authored Nov 28, 2012 by Yi Zou Committed by David S. Miller Nov 30, 2012

8021q: fix vlan device to inherit the unicast filtering capability flag



This bug is observed on running FCoE over a VLAN device associated w/
a real device that has IFF_UNICAST_FLT set since FCoE would add unicast
address such as FLOGI MAC to the VLAN interface that FCoE is on. Since
currently, VLAN device is not inheriting the IFF_UNICAST_FLT flag from the
parent real device even though the real device is capable of doing unicast
filtering. This forces the VLAN device and its real device go to promiscuous
mode unnecessarily even the added address is actually being added to the
available unicast filter table in real device.

Signed-off-by: Yi Zou <yi.zou@intel.com>
Cc: devel@open-fcoe.org
Signed-off-by: David S. Miller <davem@davemloft.net>

parent e53665c6

net/8021q/vlan.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -242,6 +242,7 @@ static int register_vlan_device(struct net_device *real_dev, u16 vlan_id)
		* hope the underlying device can handle it.
		*/
		new_dev->mtu = real_dev->mtu;
		new_dev->priv_flags \|= (real_dev->priv_flags & IFF_UNICAST_FLT);

		vlan_dev_priv(new_dev)->vlan_id = vlan_id;
		vlan_dev_priv(new_dev)->real_dev = real_dev;

Admin message