Commit 6e201c85 authored Feb 12, 2014 by Ben Hutchings Committed by David S. Miller Feb 12, 2014

ethtool: Document the general convention for VLAs in kernel space



Various ethtool command structures are declared with zero-length array
at the end which are intended to be variable-length in userland
(relying on lack of compiler bounds checking).  However, in the kernel
the structure and array are always allocated and passed to driver
operations separately.  Make that explicit.

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent f432c095

include/linux/ethtool.h

+3 −0

Original line number	Diff line number	Diff line
		@@ -183,6 +183,9 @@ static inline u32 ethtool_rxfh_indir_default(u32 index, u32 n_rx_rings)
		* hold the RTNL lock.
		*
		* See the structures used by these operations for further documentation.
		* Note that for all operations using a structure ending with a zero-
		* length array, the array is allocated separately in the kernel and
		* is passed to the driver as an additional parameter.
		*
		* See &struct net_device and &struct net_device_ops for documentation
		* of the generic netdev features interface.

Admin message