Commit 6e086437 authored Aug 18, 2009 by Frederic Weisbecker Committed by Ingo Molnar Aug 18, 2009

perf tools: Save partial non-overlapping map



The librarization of the thread helpers between annotate and
report lost some perf report specifics.

thread__insert_map() had its most uptodate version in perf
report which cared about partial map overlapping. In case of
overlap between two maps, perf annotate's version removes the
whole old map without considering if it partially or
absolutely overlaps the new map.

We exported the odd version, change it by using the perf
report version.

Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Mike Galbraith <efault@gmx.de>
LKML-Reference: <1250607843-7395-1-git-send-email-fweisbec@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

parent 4273b005

tools/perf/util/thread.c

+22 −3

Original line number	Diff line number	Diff line
		@@ -4,6 +4,7 @@
		#include <string.h>
		#include "thread.h"
		#include "util.h"
		#include "debug.h"

		static struct thread *thread__new(pid_t pid)
		{
		@@ -85,11 +86,29 @@ void thread__insert_map(struct thread self, struct map map)

		list_for_each_entry_safe(pos, tmp, &self->maps, node) {
		if (map__overlap(pos, map)) {
		if (verbose >= 2) {
		printf("overlapping maps:\n");
		map__fprintf(map, stdout);
		map__fprintf(pos, stdout);
		}

		if (map->start <= pos->start && map->end > pos->start)
		pos->start = map->end;

		if (map->end >= pos->end && map->start < pos->end)
		pos->end = map->start;

		if (verbose >= 2) {
		printf("after collision:\n");
		map__fprintf(pos, stdout);
		}

		if (pos->start >= pos->end) {
		list_del_init(&pos->node);
		/* XXX leaks dsos */
		free(pos);
		}
		}
		}

		list_add_tail(&map->node, &self->maps);
		}

Admin message