Commit 6df8c9d8 authored Jan 12, 2017 by Jeff Layton Committed by Ilya Dryomov Jan 18, 2017

ceph: fix bad endianness handling in parse_reply_info_extra



sparse says:

    fs/ceph/mds_client.c:291:23: warning: restricted __le32 degrades to integer
    fs/ceph/mds_client.c:293:28: warning: restricted __le32 degrades to integer
    fs/ceph/mds_client.c:294:28: warning: restricted __le32 degrades to integer
    fs/ceph/mds_client.c:296:28: warning: restricted __le32 degrades to integer

The op value is __le32, so we need to convert it before comparing it.

Cc: stable@vger.kernel.org # needs backporting for < 3.14
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

parent fe2ed425

fs/ceph/mds_client.c

+5 −4

Original line number	Diff line number	Diff line
		@@ -288,12 +288,13 @@ static int parse_reply_info_extra(void *p, void end,
		struct ceph_mds_reply_info_parsed *info,
		u64 features)
		{
		if (info->head->op == CEPH_MDS_OP_GETFILELOCK)
		u32 op = le32_to_cpu(info->head->op);

		if (op == CEPH_MDS_OP_GETFILELOCK)
		return parse_reply_info_filelock(p, end, info, features);
		else if (info->head->op == CEPH_MDS_OP_READDIR \|\|
		info->head->op == CEPH_MDS_OP_LSSNAP)
		else if (op == CEPH_MDS_OP_READDIR \|\| op == CEPH_MDS_OP_LSSNAP)
		return parse_reply_info_dir(p, end, info, features);
		else if (info->head->op == CEPH_MDS_OP_CREATE)
		else if (op == CEPH_MDS_OP_CREATE)
		return parse_reply_info_create(p, end, info, features);
		else
		return -EIO;

Admin message