Commit 6de56493 authored Mar 11, 2018 by OuYang ZhiZhong Committed by Boris Brezillon Mar 19, 2018

mtdchar: fix usage of mtd_ooblayout_ecc()



Section was not properly computed. The value of OOB region definition is
always ECC section 0 information in the OOB area, but we want to get all
the ECC bytes information, so we should call
mtd_ooblayout_ecc(mtd, section++, &oobregion) until it returns -ERANGE.

Fixes: c2b78452 ("mtd: use mtd_ooblayout_xxx() helpers where appropriate")
Cc: <stable@vger.kernel.org>
Signed-off-by: OuYang ZhiZhong <ouyzz@yealink.com>
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>

parent c698ca52

drivers/mtd/mtdchar.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -479,7 +479,7 @@ static int shrink_ecclayout(struct mtd_info *mtd,
		for (i = 0; i < MTD_MAX_ECCPOS_ENTRIES;) {
		u32 eccpos;

		ret = mtd_ooblayout_ecc(mtd, section, &oobregion);
		ret = mtd_ooblayout_ecc(mtd, section++, &oobregion);
		if (ret < 0) {
		if (ret != -ERANGE)
		return ret;
		@@ -526,7 +526,7 @@ static int get_oobinfo(struct mtd_info mtd, struct nand_oobinfo to)
		for (i = 0; i < ARRAY_SIZE(to->eccpos);) {
		u32 eccpos;

		ret = mtd_ooblayout_ecc(mtd, section, &oobregion);
		ret = mtd_ooblayout_ecc(mtd, section++, &oobregion);
		if (ret < 0) {
		if (ret != -ERANGE)
		return ret;

Admin message