Commit 6dbbf846 authored Nov 30, 2020 by Edmond Chung Committed by Bartosz Golaszewski Dec 02, 2020

gpiolib: Don't free if pin ranges are not defined



A similar check was added in gpiochip_generic_request, but not in free.
This has caused an imbalance count of request vs. free calls to the
pinctrl driver. This patch is targeted to fix that issue.

Fixes: 2ab73c6d ("gpio: Support GPIO controllers without pin-ranges")
Signed-off-by: Edmond Chung <edmondchung@google.com>
Signed-off-by: Andrew Chant <achant@google.com>
Signed-off-by: Will McVicker <willmcvicker@google.com>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>

parent 60593df6

drivers/gpio/gpiolib.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -1806,6 +1806,11 @@ EXPORT_SYMBOL_GPL(gpiochip_generic_request);
		*/
		void gpiochip_generic_free(struct gpio_chip *gc, unsigned offset)
		{
		#ifdef CONFIG_PINCTRL
		if (list_empty(&gc->gpiodev->pin_ranges))
		return;
		#endif

		pinctrl_gpio_free(gc->gpiodev->base + offset);
		}
		EXPORT_SYMBOL_GPL(gpiochip_generic_free);

Admin message