Commit 6da97910 authored Mar 13, 2011 by Steve French

Elminate sparse __CHECK_ENDIAN__ warnings on port conversion

Ports are __be16 not unsigned short int

Eliminates the remaining fixable endian warnings:

~/cifs-2.6$ make modules C=1 M=fs/cifs CF=-D__CHECK_ENDIAN__
CHECK fs/cifs/connect.c
fs/cifs/connect.c:2408:23: warning: incorrect type in assignment (different base types)
fs/cifs/connect.c:2408:23: expected unsigned short *sport
fs/cifs/connect.c:2408:23: got restricted __be16 *<noident>
fs/cifs/connect.c:2410:23: warning: incorrect type in assignment (different base types)
fs/cifs/connect.c:2410:23: expected unsigned short *sport
fs/cifs/connect.c:2410:23: got restricted __be16 *<noident>
fs/cifs/connect.c:2416:24: warning: incorrect type in assignment (different base types)
fs/cifs/connect.c:2416:24: expected unsigned short [unsigned] [short] <noident>
fs/cifs/connect.c:2416:24: got restricted __be16 [usertype] <noident>
fs/cifs/connect.c:2423:24: warning: incorrect type in assignment (different base types)
fs/cifs/connect.c:2423:24: expected unsigned short [unsigned] [short] <noident>
fs/cifs/connect.c:2423:24: got restricted __be16 [usertype] <noident>
fs/cifs/connect.c:2326:23: warning: incorrect type in assignment (different base types)
fs/cifs/connect.c:2326:23: expected unsigned short [unsigned] sport
fs/cifs/connect.c:2326:23: got restricted __be16 [usertype] sin6_port
fs/cifs/connect.c:2330:23: warning: incorrect type in assignment (different base types)
fs/cifs/connect.c:2330:23: expected unsigned short [unsigned] sport
fs/cifs/connect.c:2330:23: got restricted __be16 [usertype] sin_port
fs/cifs/connect.c:2394:22: warning: restricted __be16 degrades to integer

Signed-off-by: Steve French <sfrench@us.ibm.com>

parent 2e325d59

fs/cifs/connect.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -1473,7 +1473,7 @@ srcip_matches(struct sockaddr srcaddr, struct sockaddr rhs)
		static bool
		match_port(struct TCP_Server_Info server, struct sockaddr addr)
		{
		unsigned short int port, *sport;
		__be16 port, *sport;

		switch (addr->sa_family) {
		case AF_INET:
		@@ -2281,7 +2281,7 @@ static int
		generic_ip_connect(struct TCP_Server_Info *server)
		{
		int rc = 0;
		unsigned short int sport;
		__be16 sport;
		int slen, sfamily;
		struct socket *socket = server->ssocket;
		struct sockaddr *saddr;
		@@ -2366,7 +2366,7 @@ generic_ip_connect(struct TCP_Server_Info *server)
		static int
		ip_connect(struct TCP_Server_Info *server)
		{
		unsigned short int *sport;
		__be16 *sport;
		struct sockaddr_in6 addr6 = (struct sockaddr_in6 )&server->dstaddr;
		struct sockaddr_in addr = (struct sockaddr_in )&server->dstaddr;

Admin message