Commit 6d813391 authored by Paul E. McKenney's avatar Paul E. McKenney Committed by Paul E. McKenney
Browse files

rcu: Document why rcu_blocking_is_gp() is safe 



The rcu_blocking_is_gp() function tests to see if there is only one
online CPU, and if so, synchronize_sched() and friends become no-ops.
However, for larger systems, num_online_cpus() scans a large vector,
and might be preempted while doing so.  While preempted, any number
of CPUs might come online and go offline, potentially resulting in
num_online_cpus() returning 1 when there never had only been one
CPU online.  This could result in a too-short RCU grace period, which
could in turn result in total failure, except that the only way that
the grace period is too short is if there is an RCU read-side critical
section spanning it.  For RCU-sched and RCU-bh (which are the only
cases using rcu_blocking_is_gp()), RCU read-side critical sections
have either preemption or bh disabled, which prevents CPUs from going
offline.  This in turn prevents actual failures from occurring.

This commit therefore adds a large block comment to rcu_blocking_is_gp()
documenting why it is safe.  This commit also moves rcu_blocking_is_gp()
into kernel/rcutree.c, which should help prevent unwary developers from
mistaking it for a generally useful function.

Signed-off-by: default avatarPaul E. McKenney <paul.mckenney@linaro.org>
Signed-off-by: default avatarPaul E. McKenney <paulmck@linux.vnet.ibm.com>
parent dabb8aa9

include/linux/rcutree.h

+0 −7
Original line number Diff line number Diff line
@@ -98,13 +98,6 @@ extern void rcu_force_quiescent_state(void); 
extern void rcu_bh_force_quiescent_state(void);

extern void rcu_sched_force_quiescent_state(void);



/* A context switch is a grace period for RCU-sched and RCU-bh. */

static inline int rcu_blocking_is_gp(void)

{

	might_sleep();  /* Check for RCU read-side critical section. */

	return num_online_cpus() == 1;

}



extern void rcu_scheduler_starting(void);

extern int rcu_scheduler_active __read_mostly;

kernel/rcutree.c

+32 −0
Original line number Diff line number Diff line
@@ -1894,6 +1894,38 @@ void call_rcu_bh(struct rcu_head *head, void (*func)(struct rcu_head *rcu)) 
}

EXPORT_SYMBOL_GPL(call_rcu_bh);



/*

 * Because a context switch is a grace period for RCU-sched and RCU-bh,

 * any blocking grace-period wait automatically implies a grace period

 * if there is only one CPU online at any point time during execution

 * of either synchronize_sched() or synchronize_rcu_bh().  It is OK to

 * occasionally incorrectly indicate that there are multiple CPUs online

 * when there was in fact only one the whole time, as this just adds

 * some overhead: RCU still operates correctly.

 *

 * Of course, sampling num_online_cpus() with preemption enabled can

 * give erroneous results if there are concurrent CPU-hotplug operations.

 * For example, given a demonic sequence of preemptions in num_online_cpus()

 * and CPU-hotplug operations, there could be two or more CPUs online at

 * all times, but num_online_cpus() might well return one (or even zero).

 *

 * However, all such demonic sequences require at least one CPU-offline

 * operation.  Furthermore, rcu_blocking_is_gp() giving the wrong answer

 * is only a problem if there is an RCU read-side critical section executing

 * throughout.  But RCU-sched and RCU-bh read-side critical sections

 * disable either preemption or bh, which prevents a CPU from going offline.

 * Therefore, the only way that rcu_blocking_is_gp() can incorrectly return

 * that there is only one CPU when in fact there was more than one throughout

 * is when there were no RCU readers in the system.  If there are no

 * RCU readers, the grace period by definition can be of zero length,

 * regardless of the number of online CPUs.

 */

static inline int rcu_blocking_is_gp(void)

{

	might_sleep();  /* Check for RCU read-side critical section. */

	return num_online_cpus() <= 1;

}



/**

 * synchronize_sched - wait until an rcu-sched grace period has elapsed.

 *

CRA Git | Maintained and supported by SUSTech CRA and CCSE