Commit 6d765101 authored Aug 29, 2019 by Andrew Murray Committed by Greg Kroah-Hartman Sep 03, 2019

coresight: etm4x: Remove superfluous setting of os_unlock



In addition to unlocking the OS lock, etm4_os_unlock will also
set the os_unlock flag. Therefore let's avoid unnecessarily
setting os_unlock flag outside of this function.

Signed-off-by: Andrew Murray <andrew.murray@arm.com>
Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
[Fixed capital letter for "remove" in the title]
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Link: https://lore.kernel.org/r/20190829202842.580-10-mathieu.poirier@linaro.org


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 6c87bedc

drivers/hwtracing/coresight/coresight-etm4x.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -1047,10 +1047,8 @@ static int etm4_starting_cpu(unsigned int cpu)
		return 0;

		spin_lock(&etmdrvdata[cpu]->spinlock);
		if (!etmdrvdata[cpu]->os_unlock) {
		if (!etmdrvdata[cpu]->os_unlock)
		etm4_os_unlock(etmdrvdata[cpu]);
		etmdrvdata[cpu]->os_unlock = true;
		}

		if (local_read(&etmdrvdata[cpu]->mode))
		etm4_enable_hw(etmdrvdata[cpu]);

Admin message