Commit 6d514c72 authored by Bard Liao's avatar Bard Liao Committed by Mark Brown
Browse files

ASoC: rt286: fix capture doesn't work at some cases 



RT286_CBJ_CTRL1(0x4f) bit 10 is needed for headset capture. It
will be turned off when "VREF" widget is on and be turned on when
bias level is ON. It is odd. And if "VREF" is turned on in bias
level is ON, RT286_CBJ_CTRL1(0x4f) bit 10 will be turned off.
This patch move the bit control from rt286_set_bias_level and
rt298_vref_event to rt286_jack_detect. So it will be turned on
once a jack is plugged in.

Signed-off-by: default avatarBard Liao <bardliao@realtek.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 8005c49d

sound/soc/codecs/rt286.c

+3 −23
Original line number Diff line number Diff line
@@ -266,6 +266,8 @@ static int rt286_jack_detect(struct rt286_priv *rt286, bool *hp, bool *mic) 
		} else {

			*mic = false;

			regmap_write(rt286->regmap, RT286_SET_MIC1, 0x20);

			regmap_update_bits(rt286->regmap,

				RT286_CBJ_CTRL1, 0x0400, 0x0000);

		}

	} else {

		regmap_read(rt286->regmap, RT286_GET_HP_SENSE, &buf);
@@ -470,24 +472,6 @@ static int rt286_set_dmic1_event(struct snd_soc_dapm_widget *w, 
	return 0;

}



static int rt286_vref_event(struct snd_soc_dapm_widget *w,

			     struct snd_kcontrol *kcontrol, int event)

{

	struct snd_soc_codec *codec = snd_soc_dapm_to_codec(w->dapm);



	switch (event) {

	case SND_SOC_DAPM_PRE_PMU:

		snd_soc_update_bits(codec,

			RT286_CBJ_CTRL1, 0x0400, 0x0000);

		mdelay(50);

		break;

	default:

		return 0;

	}



	return 0;

}



static int rt286_ldo2_event(struct snd_soc_dapm_widget *w,

			     struct snd_kcontrol *kcontrol, int event)

{
@@ -536,7 +520,7 @@ static const struct snd_soc_dapm_widget rt286_dapm_widgets[] = { 
	SND_SOC_DAPM_SUPPLY_S("HV", 1, RT286_POWER_CTRL1,

		12, 1, NULL, 0),

	SND_SOC_DAPM_SUPPLY("VREF", RT286_POWER_CTRL1,

		0, 1, rt286_vref_event, SND_SOC_DAPM_PRE_PMU),

		0, 1, NULL, 0),

	SND_SOC_DAPM_SUPPLY_S("LDO1", 1, RT286_POWER_CTRL2,

		2, 0, NULL, 0),

	SND_SOC_DAPM_SUPPLY_S("LDO2", 2, RT286_POWER_CTRL1,
@@ -910,8 +894,6 @@ static int rt286_set_bias_level(struct snd_soc_codec *codec, 


	case SND_SOC_BIAS_ON:

		mdelay(10);

		snd_soc_update_bits(codec,

			RT286_CBJ_CTRL1, 0x0400, 0x0400);

		snd_soc_update_bits(codec,

			RT286_DC_GAIN, 0x200, 0x0);
@@ -920,8 +902,6 @@ static int rt286_set_bias_level(struct snd_soc_codec *codec, 
	case SND_SOC_BIAS_STANDBY:

		snd_soc_write(codec,

			RT286_SET_AUDIO_POWER, AC_PWRST_D3);

		snd_soc_update_bits(codec,

			RT286_CBJ_CTRL1, 0x0400, 0x0000);

		break;



	default:

CRA Git | Maintained and supported by SUSTech CRA and CCSE