Commit 6d1cfbab authored by Michael Chan's avatar Michael Chan Committed by David S. Miller
Browse files

[TG3]: Fix 5700/5701 DMA corruption on Apple G4. 



Fix 5700/5701 DMA write corruption on Apple G4 by detecting the Apple
UniNorth PCI 1.5 chipset and adjusting the DMA write boundary to 16. DMA
test fails to detect the problem with this chipset.

Thanks to Manuel Perez Ayala for reporting the problem and helping to
debug it.

Signed-off-by: default avatarMichael Chan <mchan@broadcom.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 35d1bc90

drivers/net/tg3.c

+16 −2
Original line number Diff line number Diff line
@@ -9695,10 +9695,24 @@ static int __devinit tg3_test_dma(struct tg3 *tp) 
	}

	if ((tp->dma_rwctrl & DMA_RWCTRL_WRITE_BNDRY_MASK) !=

	    DMA_RWCTRL_WRITE_BNDRY_16) {

		static struct pci_device_id dma_wait_state_chipsets[] = {

			{ PCI_DEVICE(PCI_VENDOR_ID_APPLE,

				     PCI_DEVICE_ID_APPLE_UNI_N_PCI15) },

			{ },

		};



		/* DMA test passed without adjusting DMA boundary,

		 * just restore the calculated DMA boundary

		 * now look for chipsets that are known to expose the

		 * DMA bug without failing the test.

		 */

		if (pci_dev_present(dma_wait_state_chipsets)) {

			tp->dma_rwctrl &= ~DMA_RWCTRL_WRITE_BNDRY_MASK;

			tp->dma_rwctrl |= DMA_RWCTRL_WRITE_BNDRY_16;

		}

		else

			/* Safe to use the calculated DMA boundary. */

			tp->dma_rwctrl = saved_dma_rwctrl;



		tw32(TG3PCI_DMA_RW_CTRL, tp->dma_rwctrl);

	}

include/linux/pci_ids.h

+1 −0
Original line number Diff line number Diff line
@@ -874,6 +874,7 @@ 
#define PCI_DEVICE_ID_APPLE_KL_USB_P	0x0026

#define PCI_DEVICE_ID_APPLE_UNI_N_AGP_P	0x0027

#define PCI_DEVICE_ID_APPLE_UNI_N_AGP15	0x002d

#define PCI_DEVICE_ID_APPLE_UNI_N_PCI15	0x002e

#define PCI_DEVICE_ID_APPLE_UNI_N_FW2	0x0030

#define PCI_DEVICE_ID_APPLE_UNI_N_GMAC2	0x0032

#define PCI_DEVIEC_ID_APPLE_UNI_N_ATA	0x0033

CRA Git | Maintained and supported by SUSTech CRA and CCSE