btrfs: tree-checker: add missing returns after data_ref alignment checks (6d06b0ad) · Commits · 戴 / test

There are sectorsize alignment checks that are reported but then check_extent_data_ref continues. This was not intended, wrong alignment is not a minor problem and we should return with error. CC: stable@vger.kernel.org # 5.4+ Fixes: ("btrfs: tree-checker: Add EXTENT_DATA_REF check") Reviewed-by:

Qu Wenruo <wqu@suse.com> Signed-off-by:

David Sterba <dsterba@suse.com>

fs/btrfs/tree-checker.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1424,6 +1424,7 @@ static int check_extent_data_ref(struct extent_buffer *leaf,
		"invalid item size, have %u expect aligned to %zu for key type %u",
		btrfs_item_size_nr(leaf, slot),
		sizeof(*dref), key->type);
		return -EUCLEAN;
		}
		if (!IS_ALIGNED(key->objectid, leaf->fs_info->sectorsize)) {
		generic_err(leaf, slot,
		@@ -1452,6 +1453,7 @@ static int check_extent_data_ref(struct extent_buffer *leaf,
		extent_err(leaf, slot,
		"invalid extent data backref offset, have %llu expect aligned to %u",
		offset, leaf->fs_info->sectorsize);
		return -EUCLEAN;
		}
		}
		return 0;

Admin message