Commit 6cf16115 authored by Tomohiro Kusumi's avatar Tomohiro Kusumi Committed by Martin K. Petersen
Browse files

scsi: ufs: make ufshcd_get_lists_status() register operation obvious 



It could be just cmp 0xe instead of >>1 and cmp 0x7, with readable code.

Signed-off-by: default avatarTomohiro Kusumi <tkusumi@tuxera.com>
Reviewed-by: default avatarSubhash Jadavani <subhashj@codeaurora.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent d7e2ddd5

drivers/scsi/ufs/ufshcd.c

+1 −10
Original line number Diff line number Diff line
@@ -673,16 +673,7 @@ static inline void ufshcd_outstanding_req_clear(struct ufs_hba *hba, int tag) 
 */

static inline int ufshcd_get_lists_status(u32 reg)

{

	/*

	 * The mask 0xFF is for the following HCS register bits

	 * Bit		Description

	 *  0		Device Present

	 *  1		UTRLRDY

	 *  2		UTMRLRDY

	 *  3		UCRDY

	 * 4-7		reserved

	 */

	return ((reg & 0xFF) >> 1) ^ 0x07;

	return !((reg & UFSHCD_STATUS_READY) == UFSHCD_STATUS_READY);

}



/**

drivers/scsi/ufs/ufshci.h

+4 −0
Original line number Diff line number Diff line
@@ -160,6 +160,10 @@ enum { 
#define DEVICE_ERROR_INDICATOR			UFS_BIT(5)

#define UIC_POWER_MODE_CHANGE_REQ_STATUS_MASK	UFS_MASK(0x7, 8)



#define UFSHCD_STATUS_READY	(UTP_TRANSFER_REQ_LIST_READY |\

				UTP_TASK_REQ_LIST_READY |\

				UIC_COMMAND_READY)



enum {

	PWR_OK		= 0x0,

	PWR_LOCAL	= 0x01,

CRA Git | Maintained and supported by SUSTech CRA and CCSE