Commit 6cf07a8c authored Aug 23, 2005 by Peter Chubb Committed by Tony Luck Aug 31, 2005

[IA64] Fix nasty VMLPT problem...



I've solved the problem I was having with the simulator and not
booting Debian.

The problem is that the number of bits for the virtual linear array
short-format VHPT (Virtually mapped linear page table, VMLPT for
short) is being tested incorrectly. 

There are two problems:
      1. The PAL call that should tell the kernel the size of the
      virtual address space isn't implemented for the simulator, so
      the kernel uses the default 50.  This is addressed separately
      in dc90e95f

      2.  In arch/ia64/mm/init.c there's code to calcualte the size
      of the VMLPT based on the number of implemented virtual address
      bits and the page size.  It checks to see if the VMLPT base
      address overlaps the top of the mapped region, but this check
      doesn't allow for the address space hole, and in fact will
      never trigger.

Here's an alternative test and panic, that I think is more accurate.

Signed-off-by: Peter Chubb <peterc@gelato.unsw.edu.au>
Signed-off-by: Tony Luck <tony.luck@intel.com>

parent 714d2dc1

arch/ia64/mm/init.c

+12 −3

Original line number	Diff line number	Diff line
		@@ -382,13 +382,22 @@ ia64_mmu_init (void *my_cpu_data)

		if (impl_va_bits < 51 \|\| impl_va_bits > 61)
		panic("CPU has bogus IMPL_VA_MSB value of %lu!\n", impl_va_bits - 1);
		/*
		* mapped_space_bits - PAGE_SHIFT is the total number of ptes we need,
		* which must fit into "vmlpt_bits - pte_bits" slots. Second half of
		* the test makes sure that our mapped space doesn't overlap the
		* unimplemented hole in the middle of the region.
		*/
		if ((mapped_space_bits - PAGE_SHIFT > vmlpt_bits - pte_bits) \|\|
		(mapped_space_bits > impl_va_bits - 1))
		panic("Cannot build a big enough virtual-linear page table"
		" to cover mapped address space.\n"
		" Try using a smaller page size.\n");


		/* place the VMLPT at the end of each page-table mapped region: */
		pta = POW2(61) - POW2(vmlpt_bits);

		if (POW2(mapped_space_bits) >= pta)
		panic("mm/init: overlap between virtually mapped linear page table and "
		"mapped kernel space!");
		/*
		* Set the (virtually mapped linear) page table address. Bit
		* 8 selects between the short and long format, bits 2-7 the

Admin message