Commit 6cee3821 authored by Linus Walleij's avatar Linus Walleij
Browse files

gpio/pinctrl: sunxi: stop poking around in private vars 



This kind of hacks disturbs the refactoring of the gpiolib.

The descriptor table belongs to the gpiolib, if we want to know
something about something in it, use or define the proper accessor
functions. Let's add this gpiochip_lins_is_irq() to do what the
sunxi driver is trying at so we can privatize the descriptors
properly.

Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 1c3cdb18

drivers/gpio/gpiolib.c

+9 −0
Original line number Diff line number Diff line
@@ -1857,6 +1857,15 @@ void gpiochip_unlock_as_irq(struct gpio_chip *chip, unsigned int offset) 
}

EXPORT_SYMBOL_GPL(gpiochip_unlock_as_irq);



bool gpiochip_line_is_irq(struct gpio_chip *chip, unsigned int offset)

{

	if (offset >= chip->ngpio)

		return false;



	return test_bit(FLAG_USED_AS_IRQ, &chip->gpiodev->descs[offset].flags);

}

EXPORT_SYMBOL_GPL(gpiochip_line_is_irq);



/**

 * gpiod_get_raw_value_cansleep() - return a gpio's raw value

 * @desc: gpio whose value will be returned

drivers/pinctrl/sunxi/pinctrl-sunxi.c

+2 −2
Original line number Diff line number Diff line
@@ -457,8 +457,8 @@ static int sunxi_pinctrl_gpio_get(struct gpio_chip *chip, unsigned offset) 
	struct sunxi_pinctrl *pctl = gpiochip_get_data(chip);

	u32 reg = sunxi_data_reg(offset);

	u8 index = sunxi_data_offset(offset);

	u32 set_mux = pctl->desc->irq_read_needs_mux &&

			test_bit(FLAG_USED_AS_IRQ, &chip->desc[offset].flags);

	bool set_mux = pctl->desc->irq_read_needs_mux &&

		gpiochip_line_is_irq(chip, offset);

	u32 val;



	if (set_mux)

include/linux/gpio/driver.h

+1 −0
Original line number Diff line number Diff line
@@ -208,6 +208,7 @@ extern struct gpio_chip *gpiochip_find(void *data, 
/* lock/unlock as IRQ */

int gpiochip_lock_as_irq(struct gpio_chip *chip, unsigned int offset);

void gpiochip_unlock_as_irq(struct gpio_chip *chip, unsigned int offset);

bool gpiochip_line_is_irq(struct gpio_chip *chip, unsigned int offset);



/* get driver data */

static inline void *gpiochip_get_data(struct gpio_chip *chip)

CRA Git | Maintained and supported by SUSTech CRA and CCSE