freezer: don't distinguish nosig tasks on thaw (6cd8dedc) · Commits · 戴 / test

There's no point in thawing nosig tasks before others. There's no ordering requirement between the two groups on thaw, which the staged thawing can't guarantee anyway. Simplify thaw_processes() by removing the distinction and collapsing thaw_tasks() into thaw_processes(). This will help further updates to freezer. Signed-off-by:

Tejun Heo <tj@kernel.org>

kernel/power/process.c

+7 −13

Original line number	Diff line number	Diff line
		@@ -170,34 +170,28 @@ int freeze_kernel_threads(void)
		return error;
		}

		static void thaw_tasks(bool nosig_only)
		void thaw_processes(void)
		{
		struct task_struct g, p;

		oom_killer_enable();

		printk("Restarting tasks ... ");

		thaw_workqueues();

		read_lock(&tasklist_lock);
		do_each_thread(g, p) {
		if (!freezable(p))
		continue;

		if (nosig_only && should_send_signal(p))
		continue;

		if (cgroup_freezing_or_frozen(p))
		continue;

		__thaw_task(p);
		} while_each_thread(g, p);
		read_unlock(&tasklist_lock);
		}

		void thaw_processes(void)
		{
		oom_killer_enable();

		printk("Restarting tasks ... ");
		thaw_workqueues();
		thaw_tasks(true);
		thaw_tasks(false);
		schedule();
		printk("done.\n");
		}

Admin message