Commit 6cc90a5a authored by Stephen Hemminger's avatar Stephen Hemminger Committed by David S. Miller
Browse files

sky2: don't look for VPD size 



The code to compute VPD size didn't handle some systems that use
chip without VPD. Also some of the newer chips use some additional
registers to store the actual size, and wasn't worth putting the
additional complexity in, so just remove the code.

No big loss since the code to set the VPD size was only a
convenience so that utilities would not read the extra space past
the end of the available VPD.

Move the first PCI config read earlier to detect bad hardware
where it returns all ones and refuse loading driver before furthur
damage.

Signed-off-by: default avatarStephen Hemminger <shemminger@vyatta.com>
Tested-by: default avatarAndy Whitcroft <apw@canonical.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 9cbc1cb8

drivers/net/sky2.c

+16 −15
Original line number Diff line number Diff line
@@ -4364,6 +4364,22 @@ static int __devinit sky2_probe(struct pci_dev *pdev, 
		goto err_out;

	}



	/* Get configuration information

	 * Note: only regular PCI config access once to test for HW issues

	 *       other PCI access through shared memory for speed and to

	 *	 avoid MMCONFIG problems.

	 */

	err = pci_read_config_dword(pdev, PCI_DEV_REG2, &reg);

	if (err) {

		dev_err(&pdev->dev, "PCI read config failed\n");

		goto err_out;

	}



	if (~reg == 0) {

		dev_err(&pdev->dev, "PCI configuration read error\n");

		goto err_out;

	}



	err = pci_request_regions(pdev, DRV_NAME);

	if (err) {

		dev_err(&pdev->dev, "cannot obtain PCI resources\n");
@@ -4389,21 +4405,6 @@ static int __devinit sky2_probe(struct pci_dev *pdev, 
		}

	}



	/* Get configuration information

	 * Note: only regular PCI config access once to test for HW issues

	 *       other PCI access through shared memory for speed and to

	 *	 avoid MMCONFIG problems.

	 */

	err = pci_read_config_dword(pdev, PCI_DEV_REG2, &reg);

	if (err) {

		dev_err(&pdev->dev, "PCI read config failed\n");

		goto err_out_free_regions;

	}



	/* size of available VPD, only impact sysfs */

	err = pci_vpd_truncate(pdev, 1ul << (((reg & PCI_VPD_ROM_SZ) >> 14) + 8));

	if (err)

		dev_warn(&pdev->dev, "Can't set VPD size\n");



#ifdef __BIG_ENDIAN

	/* The sk98lin vendor driver uses hardware byte swapping but

CRA Git | Maintained and supported by SUSTech CRA and CCSE