Commit 6cc4b6e8 authored Dec 04, 2015 by Bob Peterson

GFS2: Don't do glock put on when inode creation fails

Currently the error path of function gfs2_inode_lookup calls function
gfs2_glock_put corresponding to an earlier call to gfs2_glock_get for
the inode glock. That's wrong because the error path also calls
iget_failed() which eventually calls iput, which eventually calls
gfs2_evict_inode, which does another gfs2_glock_put. This double-put
can cause the glock reference count to get off.

Signed-off-by: Bob Peterson <rpeterso@redhat.com>

parent 5ea31bc0

fs/gfs2/inode.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -198,7 +198,6 @@ fail_iopen:
		gfs2_glock_put(io_gl);
		fail_put:
		ip->i_gl->gl_object = NULL;
		gfs2_glock_put(ip->i_gl);
		fail:
		iget_failed(inode);
		return ERR_PTR(error);

Admin message