Commit 6cc2baf6 authored Dec 28, 2018 by Michal Hocko Committed by Linus Torvalds Dec 28, 2018

mm, memory_hotplug: drop pointless block alignment checks from __offline_pages

This function is never called from a context which would provide
misaligned pfn range so drop the pointless check.

Link: http://lkml.kernel.org/r/20181107101830.17405-4-mhocko@kernel.org


Signed-off-by: Michal Hocko <mhocko@suse.com>
Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
Reviewed-by: Oscar Salvador <osalvador@suse.de>
Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: Baoquan He <bhe@redhat.com>
Cc: Oscar Salvador <OSalvador@suse.com>
Cc: William Kucharski <william.kucharski@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent e0392cf7

mm/memory_hotplug.c

+0 −6

Original line number	Diff line number	Diff line
		@@ -1554,12 +1554,6 @@ static int __ref __offline_pages(unsigned long start_pfn,
		struct zone *zone;
		struct memory_notify arg;

		/* at least, alignment against pageblock is necessary */
		if (!IS_ALIGNED(start_pfn, pageblock_nr_pages))
		return -EINVAL;
		if (!IS_ALIGNED(end_pfn, pageblock_nr_pages))
		return -EINVAL;

		mem_hotplug_begin();

		/* This makes hotplug much easier...and readable.

Admin message