platform/x86: dell-laptop: fix rfkill functionality (6cc13c28) · Commits · 戴 / test

When converting the driver two arguments were transposed leading to rfkill not working. BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=201427 Reported-by:

Pepijn de Vos <pepijndevos@gmail.com> Fixes: 549b49 ("platform/x86: dell-smbios: Introduce dispatcher for SMM calls") Signed-off-by:

Pali Rohár <pali.rohar@gmail.com> Cc: <stable@vger.kernel.org> # 4.14.x Signed-off-by:

drivers/platform/x86/dell-laptop.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -531,7 +531,7 @@ static void dell_rfkill_query(struct rfkill rfkill, void data)
		return;
		}

		dell_fill_request(&buffer, 0, 0x2, 0, 0);
		dell_fill_request(&buffer, 0x2, 0, 0, 0);
		ret = dell_send_request(&buffer, CLASS_INFO, SELECT_RFKILL);
		hwswitch = buffer.output[1];

		@@ -562,7 +562,7 @@ static int dell_debugfs_show(struct seq_file s, void data)
		return ret;
		status = buffer.output[1];

		dell_fill_request(&buffer, 0, 0x2, 0, 0);
		dell_fill_request(&buffer, 0x2, 0, 0, 0);
		hwswitch_ret = dell_send_request(&buffer, CLASS_INFO, SELECT_RFKILL);
		if (hwswitch_ret)
		return hwswitch_ret;
		@@ -647,7 +647,7 @@ static void dell_update_rfkill(struct work_struct *ignored)
		if (ret != 0)
		return;

		dell_fill_request(&buffer, 0, 0x2, 0, 0);
		dell_fill_request(&buffer, 0x2, 0, 0, 0);
		ret = dell_send_request(&buffer, CLASS_INFO, SELECT_RFKILL);

		if (ret == 0 && (status & BIT(0)))