Commit 6cb47ed7 authored May 12, 2014 by Cho KyongHo Committed by Joerg Roedel May 13, 2014

iommu/exynos: Add missing cache flush for removed page table entries



This commit adds cache flush for removed small and large page entries
in exynos_iommu_unmap(). Missing cache flush of removed page table
entries can cause missing page fault interrupt when a master IP
accesses an unmapped area.

Reviewed-by: Tomasz Figa <t.figa@samsung.com>
Tested-by: Grant Grundler <grundler@chromium.org>
Signed-off-by: Cho KyongHo <pullip.cho@samsung.com>
Signed-off-by: Shaik Ameer Basha <shaik.ameer@samsung.com>
Signed-off-by: Joerg Roedel <jroedel@suse.de>

parent 8f8fcf97

drivers/iommu/exynos-iommu.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -904,6 +904,7 @@ static size_t exynos_iommu_unmap(struct iommu_domain *domain,
		if (lv2ent_small(ent)) {
		*ent = 0;
		size = SPAGE_SIZE;
		pgtable_flush(ent, ent + 1);
		priv->lv2entcnt[lv1ent_offset(iova)] += 1;
		goto done;
		}
		@@ -915,6 +916,7 @@ static size_t exynos_iommu_unmap(struct iommu_domain *domain,
		}

		memset(ent, 0, sizeof(ent) SPAGES_PER_LPAGE);
		pgtable_flush(ent, ent + SPAGES_PER_LPAGE);

		size = LPAGE_SIZE;
		priv->lv2entcnt[lv1ent_offset(iova)] += SPAGES_PER_LPAGE;

Admin message