Commit 6c9fe14f authored Jan 20, 2015 by Qu Wenruo Committed by Chris Mason Jan 20, 2015

btrfs: Fix the bug that fs_info->pending_changes is never cleared.



Fs_info->pending_changes is never cleared since the original code uses
cmpxchg(&fs_info->pending_changes, 0, 0), which will only clear it if
pending_changes is already 0.

This will cause a lot of problem when mount it with inode_cache mount
option.
If the btrfs is mounted as inode_cache, pending_changes will always be
1, even when the fs is frozen.

Signed-off-by: Qu Wenruo <quwenruo@cn.fujitsu.com>
Reviewed-by: David Sterba <dsterba@suse.cz>
Signed-off-by: David Sterba <dsterba@suse.cz>
Signed-off-by: Chris Mason <clm@fb.com>

parent 6e1103a6

fs/btrfs/transaction.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2118,7 +2118,7 @@ void btrfs_apply_pending_changes(struct btrfs_fs_info *fs_info)
		unsigned long prev;
		unsigned long bit;

		prev = cmpxchg(&fs_info->pending_changes, 0, 0);
		prev = xchg(&fs_info->pending_changes, 0);
		if (!prev)
		return;

Admin message