Commit 6c849caf authored Mar 04, 2017 by simran singhal Committed by Greg Kroah-Hartman Mar 09, 2017

staging: vc04_services: Clean up tests if NULL returned on failure



Some functions like kmalloc/kzalloc return NULL on failure.
When NULL represents failure, !x is commonly used.

This was done using Coccinelle:
@@
expression *e;
identifier l1;
@@

e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...);
...
- e == NULL
+ !e

Signed-off-by: simran singhal <singhalsimran0@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 4e1c89de

drivers/staging/vc04_services/interface/vchiq_arm/vchiq_util.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -52,7 +52,7 @@ int vchiu_queue_init(VCHIU_QUEUE_T *queue, int size)
		sema_init(&queue->push, 0);

		queue->storage = kzalloc(size * sizeof(VCHIQ_HEADER_T *), GFP_KERNEL);
		if (queue->storage == NULL) {
		if (!queue->storage) {
		vchiu_queue_delete(queue);
		return 0;
		}

Admin message