Commit 6c8116c9 authored Mar 19, 2020 by Tao Zhou Committed by Peter Zijlstra Mar 20, 2020

sched/fair: Fix condition of avg_load calculation



In update_sg_wakeup_stats(), the comment says:

Computing avg_load makes sense only when group is fully
busy or overloaded.

But, the code below this comment does not check like this.

From reading the code about avg_load in other functions, I
confirm that avg_load should be calculated in fully busy or
overloaded case. The comment is correct and the checking
condition is wrong. So, change that condition.

Fixes: 57abff06 ("sched/fair: Rework find_idlest_group()")
Signed-off-by: Tao Zhou <ouwen210@hotmail.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
Acked-by: Mel Gorman <mgorman@suse.de>
Link: https://lkml.kernel.org/r/Message-ID:

parent e94f80f6

kernel/sched/fair.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -8631,7 +8631,8 @@ static inline void update_sg_wakeup_stats(struct sched_domain *sd,
		* Computing avg_load makes sense only when group is fully busy or
		* overloaded
		*/
		if (sgs->group_type < group_fully_busy)
		if (sgs->group_type == group_fully_busy \|\|
		sgs->group_type == group_overloaded)
		sgs->avg_load = (sgs->group_load * SCHED_CAPACITY_SCALE) /
		sgs->group_capacity;
		}

Admin message