Commit 6c79bf0f authored by Bart De Schuymer's avatar Bart De Schuymer Committed by Patrick McHardy
Browse files

netfilter: bridge-netfilter: fix refragmenting IP traffic encapsulated in PPPoE traffic 



The MTU for IP traffic encapsulated inside PPPoE traffic is smaller
than the MTU of the Ethernet device (1500). Connection tracking
gathers all IP packets and sometimes will refragment them in
ip_fragment(). We then need to subtract the length of the
encapsulating header from the mtu used in ip_fragment(). The check in
br_nf_dev_queue_xmit() which determines if ip_fragment() has to be
called is also updated for the PPPoE-encapsulated packets.
nf_bridge_copy_header() is also updated to make sure the PPPoE data
length field has the correct value.

Signed-off-by: default avatarBart De Schuymer <bdschuym@pandora.be>
Signed-off-by: default avatarPatrick McHardy <kaber@trash.net>
parent 62910554

include/linux/netfilter_bridge.h

+7 −0
Original line number Diff line number Diff line
@@ -68,6 +68,13 @@ static inline unsigned int nf_bridge_encap_header_len(const struct sk_buff *skb) 
	}

}



static inline unsigned int nf_bridge_mtu_reduction(const struct sk_buff *skb)

{

	if (unlikely(skb->nf_bridge->mask & BRNF_PPPoE))

		return PPPOE_SES_HLEN;

	return 0;

}



extern int br_handle_frame_finish(struct sk_buff *skb);

/* Only used in br_device.c */

static inline int br_nf_pre_routing_finish_bridge_slow(struct sk_buff *skb)

net/bridge/br_netfilter.c

+1 −1
Original line number Diff line number Diff line
@@ -745,7 +745,7 @@ static unsigned int br_nf_forward_arp(unsigned int hook, struct sk_buff *skb, 
static int br_nf_dev_queue_xmit(struct sk_buff *skb)

{

	if (skb->nfct != NULL && skb->protocol == htons(ETH_P_IP) &&

	    skb->len > skb->dev->mtu &&

	    skb->len + nf_bridge_mtu_reduction(skb) > skb->dev->mtu &&

	    !skb_is_gso(skb))

		return ip_fragment(skb, br_dev_queue_push_xmit);

	else

net/ipv4/ip_output.c

+4 −0
Original line number Diff line number Diff line
@@ -469,6 +469,10 @@ int ip_fragment(struct sk_buff *skb, int (*output)(struct sk_buff *)) 


	hlen = iph->ihl * 4;

	mtu = dst_mtu(&rt->u.dst) - hlen;	/* Size of data space */

#ifdef CONFIG_BRIDGE_NETFILTER

	if (skb->nf_bridge)

		mtu -= nf_bridge_mtu_reduction(skb);

#endif

	IPCB(skb)->flags |= IPSKB_FRAG_COMPLETE;



	/* When frag_list is given, use it. First, check its validity:

CRA Git | Maintained and supported by SUSTech CRA and CCSE