Commit 6c5bc8fe authored by Michal Kubecek's avatar Michal Kubecek Committed by David S. Miller
Browse files

ethtool: add EEE_NTF notification 



Send ETHTOOL_MSG_EEE_NTF notification whenever EEE settings of a network
device are modified using ETHTOOL_MSG_EEE_SET netlink message or
ETHTOOL_SEEE ioctl request.

Signed-off-by: default avatarMichal Kubecek <mkubecek@suse.cz>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent fd77be7b

Documentation/networking/ethtool-netlink.rst

+1 −0
Original line number Diff line number Diff line
@@ -232,6 +232,7 @@ Kernel to userspace: 
  ``ETHTOOL_MSG_PAUSE_GET_REPLY``       pause parameters

  ``ETHTOOL_MSG_PAUSE_NTF``             pause parameters

  ``ETHTOOL_MSG_EEE_GET_REPLY``         EEE settings

  ``ETHTOOL_MSG_EEE_NTF``               EEE settings

  ===================================== =================================



``GET`` requests are sent by userspace applications to retrieve device

include/uapi/linux/ethtool_netlink.h

+1 −0
Original line number Diff line number Diff line
@@ -71,6 +71,7 @@ enum { 
	ETHTOOL_MSG_PAUSE_GET_REPLY,

	ETHTOOL_MSG_PAUSE_NTF,

	ETHTOOL_MSG_EEE_GET_REPLY,

	ETHTOOL_MSG_EEE_NTF,



	/* add new constants above here */

	__ETHTOOL_MSG_KERNEL_CNT,

net/ethtool/eee.c

+3 −0
Original line number Diff line number Diff line
@@ -192,6 +192,9 @@ int ethnl_set_eee(struct sk_buff *skb, struct genl_info *info) 
		goto out_ops;



	ret = dev->ethtool_ops->set_eee(dev, &eee);

	if (ret < 0)

		goto out_ops;

	ethtool_notify(dev, ETHTOOL_MSG_EEE_NTF, NULL);



out_ops:

	ethnl_ops_complete(dev);

net/ethtool/ioctl.c

+5 −1
Original line number Diff line number Diff line
@@ -1354,6 +1354,7 @@ static int ethtool_get_eee(struct net_device *dev, char __user *useraddr) 
static int ethtool_set_eee(struct net_device *dev, char __user *useraddr)

{

	struct ethtool_eee edata;

	int ret;



	if (!dev->ethtool_ops->set_eee)

		return -EOPNOTSUPP;
@@ -1361,7 +1362,10 @@ static int ethtool_set_eee(struct net_device *dev, char __user *useraddr) 
	if (copy_from_user(&edata, useraddr, sizeof(edata)))

		return -EFAULT;



	return dev->ethtool_ops->set_eee(dev, &edata);

	ret = dev->ethtool_ops->set_eee(dev, &edata);

	if (!ret)

		ethtool_notify(dev, ETHTOOL_MSG_EEE_NTF, NULL);

	return ret;

}



static int ethtool_nway_reset(struct net_device *dev)

net/ethtool/netlink.c

+2 −0
Original line number Diff line number Diff line
@@ -548,6 +548,7 @@ ethnl_default_notify_ops[ETHTOOL_MSG_KERNEL_MAX + 1] = { 
	[ETHTOOL_MSG_CHANNELS_NTF]	= &ethnl_channels_request_ops,

	[ETHTOOL_MSG_COALESCE_NTF]	= &ethnl_coalesce_request_ops,

	[ETHTOOL_MSG_PAUSE_NTF]		= &ethnl_pause_request_ops,

	[ETHTOOL_MSG_EEE_NTF]		= &ethnl_eee_request_ops,

};



/* default notification handler */
@@ -639,6 +640,7 @@ static const ethnl_notify_handler_t ethnl_notify_handlers[] = { 
	[ETHTOOL_MSG_CHANNELS_NTF]	= ethnl_default_notify,

	[ETHTOOL_MSG_COALESCE_NTF]	= ethnl_default_notify,

	[ETHTOOL_MSG_PAUSE_NTF]		= ethnl_default_notify,

	[ETHTOOL_MSG_EEE_NTF]		= ethnl_default_notify,

};



void ethtool_notify(struct net_device *dev, unsigned int cmd, const void *data)

CRA Git | Maintained and supported by SUSTech CRA and CCSE