Commit 6c1e4591 authored by Doug Smythies's avatar Doug Smythies Committed by Rafael J. Wysocki
Browse files

intel_pstate: Force setting target pstate when required 



During initialization and exit it is possible that the target pstate
might not actually be set. Furthermore, the result can be that the
driver and the processor are out of synch and, under some conditions,
the driver might never send the processor the proper target pstate.

This patch adds a bypass or do_checks flag to the call to
intel_pstate_set_pstate. If bypass, then specifically bypass clamp
checks and the do not send if it is the same as last time check. If
do_checks, then, and as before, do the current policy clamp checks,
and do not do actual send if the new target is the same as the old.

Signed-off-by: default avatarDoug Smythies <dsmythies@telus.net>
Reported-by: default avatarMarien Zwart <marien.zwart@gmail.com>
Reported-by: default avatarAlex Lochmann <alexander.lochmann@tu-dortmund.de>
Reported-by: default avatarPiotr Ko?aczkowski <pkolaczk@gmail.com>
Reported-by: default avatarClemens Eisserer <linuxhippy@gmail.com>
Tested-by: default avatarMarien Zwart <marien.zwart@gmail.com>
Tested-by: default avatarDoug Smythies <dsmythies@telus.net>
[ rjw: Dropped pointless symbol definitions, rebased ]
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent f16255eb

drivers/cpufreq/intel_pstate.c

+11 −10
Original line number Diff line number Diff line
@@ -706,10 +706,11 @@ static void intel_pstate_get_min_max(struct cpudata *cpu, int *min, int *max) 
	*min = clamp_t(int, min_perf, cpu->pstate.min_pstate, max_perf);

}



static void intel_pstate_set_pstate(struct cpudata *cpu, int pstate)

static void intel_pstate_set_pstate(struct cpudata *cpu, int pstate, bool force)

{

	int max_perf, min_perf;



	if (force) {

		update_turbo_state();



		intel_pstate_get_min_max(cpu, &min_perf, &max_perf);
@@ -718,7 +719,7 @@ static void intel_pstate_set_pstate(struct cpudata *cpu, int pstate) 


		if (pstate == cpu->pstate.current_pstate)

			return;



	}

	trace_cpu_frequency(pstate * cpu->pstate.scaling, cpu->cpu);



	cpu->pstate.current_pstate = pstate;
@@ -735,7 +736,7 @@ static void intel_pstate_get_cpu_pstates(struct cpudata *cpu) 


	if (pstate_funcs.get_vid)

		pstate_funcs.get_vid(cpu);

	intel_pstate_set_pstate(cpu, cpu->pstate.min_pstate);

	intel_pstate_set_pstate(cpu, cpu->pstate.min_pstate, false);

}



static inline void intel_pstate_calc_busy(struct cpudata *cpu)
@@ -855,7 +856,7 @@ static inline void intel_pstate_adjust_busy_pstate(struct cpudata *cpu) 
	ctl = pid_calc(pid, busy_scaled);



	/* Negative values of ctl increase the pstate and vice versa */

	intel_pstate_set_pstate(cpu, cpu->pstate.current_pstate - ctl);

	intel_pstate_set_pstate(cpu, cpu->pstate.current_pstate - ctl, true);



	sample = &cpu->sample;

	trace_pstate_sample(fp_toint(sample->core_pct_busy),
@@ -1018,7 +1019,7 @@ static void intel_pstate_stop_cpu(struct cpufreq_policy *policy) 
	if (hwp_active)

		return;



	intel_pstate_set_pstate(cpu, cpu->pstate.min_pstate);

	intel_pstate_set_pstate(cpu, cpu->pstate.min_pstate, false);

}



static int intel_pstate_cpu_init(struct cpufreq_policy *policy)

CRA Git | Maintained and supported by SUSTech CRA and CCSE