Commit 6c18a6b4 authored Nov 03, 2016 by Felix Fietkau Committed by Johannes Berg Nov 15, 2016

Revert "mac80211: allow using AP_LINK_PS with mac80211-generated TIM IE"



This reverts commit c68df2e7.

__sta_info_recalc_tim turns into a no-op if local->ops->set_tim is not
set. This prevents the beacon TIM bit from being set for all drivers
that do not implement this op (almost all of them), thus thoroughly
essential AP mode powersave functionality.

Cc: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Fixes: c68df2e7 ("mac80211: allow using AP_LINK_PS with mac80211-generated TIM IE")
Signed-off-by: Felix Fietkau <nbd@nbd.name>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>

parent c8eaf347

net/mac80211/sta_info.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -688,7 +688,7 @@ static void __sta_info_recalc_tim(struct sta_info *sta, bool ignore_pending)
		}

		/* No need to do anything if the driver does all */
		if (!local->ops->set_tim)
		if (ieee80211_hw_check(&local->hw, AP_LINK_PS))
		return;

		if (sta->dead)

Admin message